Skip to content

Sync scheduler schedule from runtime target#180

Merged
Pigbibi merged 1 commit into
mainfrom
codex/runtime-scheduler-plan-20260619
Jun 18, 2026
Merged

Sync scheduler schedule from runtime target#180
Pigbibi merged 1 commit into
mainfrom
codex/runtime-scheduler-plan-20260619

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • read scheduler plans from RUNTIME_TARGET_JSON during env sync
  • allow full 5-field cron overrides for DCA and snapshot windows
  • keep legacy 2-field time override behavior

Tests

  • bash tests/test_sync_cloud_run_env_workflow.sh

@Pigbibi Pigbibi merged commit f100266 into main Jun 18, 2026
1 check passed
@Pigbibi Pigbibi deleted the codex/runtime-scheduler-plan-20260619 branch June 18, 2026 17:35

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 80b6c1ff36

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

runtime_target = json.loads(raw_runtime_target)
except json.JSONDecodeError:
runtime_target = {}
scheduler = runtime_target.get("scheduler") if isinstance(runtime_target, dict) else {}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Read scheduler plans from execution_windows

When the selected runtime target carries scheduler data through the pinned quant_platform_kit.common.runtime_target.RuntimeTarget, to_dict() serializes it under execution_windows, not scheduler. In any deployment that sets schedules via build_runtime_target(execution_windows=...), this lookup leaves runtime_scheduler empty and the workflow silently falls back to the legacy CLOUD_SCHEDULER_*_TIME values, so the new runtime-target schedule sync never applies.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant